From ecf922b8bbad7c60472b39b4bc5c00c9e0b3bdfb Mon Sep 17 00:00:00 2001 From: Sam Hemelryk Date: Wed, 4 Nov 2009 02:46:18 +0000 Subject: [PATCH] forum MDL-20737 Fixed bug causing exception in forum move to drop down --- mod/forum/discuss.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/mod/forum/discuss.php b/mod/forum/discuss.php index 241d05e53c..523b03c727 100644 --- a/mod/forum/discuss.php +++ b/mod/forum/discuss.php @@ -217,6 +217,19 @@ } } if (!empty($forummenu)) { + + // Check for empty groups... This can occur if there is the forum we are in is + // the only forum within its course section. + foreach ($forummenu as $key=>$item) { + // If this option is a group and the next option is a group OR it is + // the last item in the array then remove it... or we get an exception + if (strpos($item, '--------------')===0 && (!array_key_exists($key+1, $forummenu) || strpos($forummenu[$key+1], '--------------')===0)) { + // Remember foreach acts on a copy of the array so things + // will not get out of order + unset($forummenu[$key]); + } + } + echo "
"; $select = html_select::make_popup_form('', '', $forummenu, 'forummenu'); $select->nothinglabel = get_string("movethisdiscussionto", "forum"); -- 2.39.5