From fca90882442b2442d56add48184e35094e03cad7 Mon Sep 17 00:00:00 2001 From: scyrma Date: Tue, 29 Apr 2008 03:30:01 +0000 Subject: [PATCH] MDL-14588 - Prevent error message when calling function with null variable (merge from 1.9) --- question/backuplib.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/question/backuplib.php b/question/backuplib.php index 4588681bd0..aee1cb568c 100644 --- a/question/backuplib.php +++ b/question/backuplib.php @@ -459,14 +459,17 @@ function question_insert_c_and_q_ids_for_module($backup_unique_code, $course, $modulename, $instances){ global $CFG; $status = true; - // using 'dummykeyname' in sql because otherwise get_records_sql_menu returns an error + // using 'dummykeyname' in sql because otherwise get_records_sql_menu returns an error // if two key names are the same. - $cmcontexts = get_records_sql_menu("SELECT c.id, c.id AS dummykeyname FROM {$CFG->prefix}modules m, + $cmcontexts = array(); + if(!empty($instances)) { + $cmcontexts = get_records_sql_menu("SELECT c.id, c.id AS dummykeyname FROM {$CFG->prefix}modules m, {$CFG->prefix}course_modules cm, {$CFG->prefix}context c WHERE m.name = '$modulename' AND m.id = cm.module AND cm.id = c.instanceid AND c.contextlevel = ".CONTEXT_MODULE." AND cm.course = $course AND cm.instance IN (".implode(',',array_keys($instances)).")"); + } if ($cmcontexts){ $status = $status && execute_sql("INSERT INTO {$CFG->prefix}backup_ids -- 2.39.5