From fea42164fbd59b380ea5799fd7096e3fd7f3551f Mon Sep 17 00:00:00 2001 From: vinkmar Date: Sat, 19 Aug 2006 02:21:44 +0000 Subject: [PATCH] preventing notifications by using isset() unsparingly (i.e. small bug fixes) --- blocks/admin_bookmarks/block_admin_bookmarks.php | 1 + blocks/admin_bookmarks/create.php | 2 +- blocks/admin_bookmarks/delete.php | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/blocks/admin_bookmarks/block_admin_bookmarks.php b/blocks/admin_bookmarks/block_admin_bookmarks.php index b49e54c620..f76ebe07fb 100644 --- a/blocks/admin_bookmarks/block_admin_bookmarks.php +++ b/blocks/admin_bookmarks/block_admin_bookmarks.php @@ -32,6 +32,7 @@ class block_admin_bookmarks extends block_base { } $this->content = new stdClass; + $this->content->text = ''; if (isset($USER->preference['admin_bookmarks'])) { $bookmarks = explode(',',$USER->preference['admin_bookmarks']); // hmm... just a liiitle (potentially) processor-intensive diff --git a/blocks/admin_bookmarks/create.php b/blocks/admin_bookmarks/create.php index de96060655..2d2e3df4f9 100644 --- a/blocks/admin_bookmarks/create.php +++ b/blocks/admin_bookmarks/create.php @@ -6,7 +6,7 @@ require_once($CFG->dirroot . '/admin/adminlib.php'); if ($section = optional_param('section', '', PARAM_ALPHAEXT)) { - if ($USER->preference['admin_bookmarks']) { + if (isset($USER->preference['admin_bookmarks'])) { $bookmarks = explode(',',$USER->preference['admin_bookmarks']); if (in_array($section, $bookmarks)) { diff --git a/blocks/admin_bookmarks/delete.php b/blocks/admin_bookmarks/delete.php index d482d4de66..e53f1f29cb 100644 --- a/blocks/admin_bookmarks/delete.php +++ b/blocks/admin_bookmarks/delete.php @@ -6,7 +6,7 @@ require_once($CFG->dirroot . '/admin/adminlib.php'); if ($section = optional_param('section', '', PARAM_ALPHAEXT)) { - if ($USER->preference['admin_bookmarks']) { + if (isset($USER->preference['admin_bookmarks'])) { $bookmarks = explode(',', $USER->preference['admin_bookmarks']); -- 2.39.5